follow ros convention for build destination folders #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My bad, I got it working without the need for this change. I must have missed something in my catkin config when I tried it the first time. Feel free to close this PR if you don't see any value in using the catkin cmake variables |
|
The only thing I really care about is to store the plugins in the same folder as the executable. Both versions should work just fine. I will merge. Thanks |
facontidavide
added a commit
that referenced
this pull request
Apr 21, 2017
follow ros convention for build destination folders
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
${CATKIN_PACKAGE_LIB_DESTINATION}and${CATKIN_PACKAGE_BIN_DESTINATION}variables to allow the build products to be found by ros tools (e.g.rosrun)This will also allow better support of isolated/non-isolated builds.