Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataLoadMCAP: add support to mcap logTime #1037

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

lucabart97
Copy link
Contributor

@lucabart97 lucabart97 commented Jan 23, 2025

The DataLoadMCAP plugin support only the publishTime of the mcap message. Add a radio button in the load dialog to select the logTime or publishTime.

Copy link
Owner

@facontidavide facontidavide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that a Radio button is better than a checkbox, to make clearer to the user what the alternatives are.

@lucabart97
Copy link
Contributor Author

lucabart97 commented Jan 24, 2025

Got it!
(Use publishTime as the default value, as before)
Selection_009

@lucabart97 lucabart97 force-pushed the main branch 2 times, most recently from d8bf606 to e10698e Compare January 24, 2025 10:06
The DataLoadMCAP plugin support only the publishTime of the mcap
message. Add a radio button in the load dialog to select the
logTime or publishTime.

Signed-off-by: Luca Bartoli <[email protected]>
@facontidavide facontidavide merged commit 6fa3779 into facontidavide:main Jan 24, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants