Skip to content
This repository has been archived by the owner on Feb 13, 2025. It is now read-only.

NLE 1.1.0 Upgrade #110

Merged
merged 21 commits into from
Feb 6, 2025
Merged

NLE 1.1.0 Upgrade #110

merged 21 commits into from
Feb 6, 2025

Conversation

StephenOman
Copy link
Contributor

@StephenOman StephenOman commented Jan 22, 2025 •
edited
Loading

Overview

This PR updates MiniHack to use the latest NetHack Learning Environment (NLE) version 1.1.0. This version of NLE uses Farama Foundation Gymnasium, the successor to the deprecated OpenAI Gym.

It addresses issue #98

Additional Changes

  • Bug in the LocActionEvent class in reward_manager where the check() method assumes that an action has already occurred and this may not be the case
  • Bug referencing uninitialised variables (_previous_obs & _previous_action) in _is_episode_end(). These are initiated in the MiniHack class
  • Support for Python versions 3.10, 3.11 & 3.12 added
  • Upgraded GitHub Actions to latest versions
  • Minor documentation changes

@StephenOman
Change README url to point to new NLE repo
cce7b4a
@StephenOman
Remove NLE version and replace gym with gymnasium in setup.py
064eccb
@StephenOman
Update reference URLs to link to new NLE repo
9956eaf
@StephenOman
Update references from gym to gymnasium
0fe976d
@StephenOman
Update env_list script for gymnasium api alignment
fc40a03
@StephenOman
Update Gymnasium API calls in play script
d2e05a9
@StephenOman
Update calls to render() for Gymnasium API alignment
b945c27
@StephenOman
Update calls to step() function for Gymnasium API alignment
7115e0d
@StephenOman
Update return values of reset() to match Gymnasium API
f7cde9b
@StephenOman
Update Test Gymnasium API calls, initialise internal variables in bas…
cd02987 
…e class and add check for no previous action in episode end.
@StephenOman
Fix URL typo
af22cb7
@StephenOman
Add vscode to gitignore
56629d5
@StephenOman
Update GitHub Actions versions
20c96b8
@StephenOman
Synchronise Python versions to NLE
f5a1e5d
@StephenOman
Add new supported python versions to setup.py
7318cf5
@StephenOman
Add truncated to env.step returns and flag follow up TODO actions
2fef7da
@StephenOman
Remove TODO tags and minor documentation fixes
0fa4289
@StephenOman
Add explicit setuptools dependency to install in Python 3.12
631bac9
@StephenOman
Remove TODO labels and add comments for truncated flag
02aa285
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
@github-actions github-actions bot added core docker Contributions to our dockers containers. envs Contributions to MiniHack environments tests Contributions to our tests. labels Jan 22, 2025
This was referenced Jan 27, 2025
Closed
Closed
Merged
@minqi minqi merged commit e491a30 into facebookresearch:main Feb 6, 2025
2 checks passed
@samvelyan samvelyan mentioned this pull request Feb 6, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samvelyan samvelyan samvelyan approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. core docker Contributions to our dockers containers. envs Contributions to MiniHack environments tests Contributions to our tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StephenOman @samvelyan @minqi @facebook-github-bot