Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a conda recipe #1717

Closed
erip opened this issue Feb 17, 2020 · 4 comments
Closed

Create a conda recipe #1717

erip opened this issue Feb 17, 2020 · 4 comments

Comments

@erip
Copy link
Contributor

erip commented Feb 17, 2020

🚀 Feature Request

fairseq should be available from the pytorch conda channel.

Motivation

In order to install fairseq currently, a C++ compiler with loads of native dependencies and linked libraries is a requirement. This is a heavy dependency in some runtimes.

Pitch

A conda recipe for fairseq should be created which targets the three big umbrella runtimes: linux, os x, and win64. These artifacts should have CPU and GPU versions for all supported pythons to mirror other pytorch conda artifacts.

Alternatives

fairseq could be made available through pypi with precompiled .whls to avoid fiddliness of compiling from source.

@lematt1991
Copy link
Contributor

I agree this would be great

In order to install fairseq currently, a C++ compiler with loads of native dependencies and linked libraries is a requirement. This is a heavy dependency in some runtimes.

Are there really loads of C++ dependencies? I think all of our non-python code should be pretty self-contained.

@erip
Copy link
Contributor Author

erip commented Feb 18, 2020

Sorry, I meant system dependencies (i.e., a compiler and accompanying headers, etc.). Not literal package dependencies

facebook-github-bot pushed a commit that referenced this issue Mar 21, 2021
Summary: Pull Request resolved: fairinternal/fairseq-py#1717

Reviewed By: alexeib

Differential Revision: D27156919

Pulled By: myleott

fbshipit-source-id: af3c2e41464c04a7808f40894e7b0106798e4822
sshleifer pushed a commit that referenced this issue Apr 7, 2021
Summary: Pull Request resolved: fairinternal/fairseq-py#1717

Reviewed By: alexeib

Differential Revision: D27156919

Pulled By: myleott

fbshipit-source-id: af3c2e41464c04a7808f40894e7b0106798e4822
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Apr 17, 2022
@stale
Copy link

stale bot commented Apr 28, 2022

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants