Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tmToString and relating document #8250

Closed
wants to merge 1 commit into from
Closed

Improve tmToString and relating document #8250

wants to merge 1 commit into from

Conversation

rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented Jan 4, 2024

Add examples for skipTrailingZeros and zeroPaddingYear. Skip an extra
branch when skipTrailingZeros is disabled.

@netlify Netlify
Copy link

netlify bot commented Jan 4, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b268b92
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/65960fa83889c20008c33938

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 4, 2024
@rui-mo rui-mo mentioned this pull request Jan 4, 2024
Closed
@mbasmanova mbasmanova requested a review from Yuhta January 4, 2024 06:01
mbasmanova
mbasmanova approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in a289ac7.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit a289ac7e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasmanova mbasmanova mbasmanova approved these changes

@Yuhta Yuhta Awaiting requested review from Yuhta

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rui-mo @facebook-github-bot @mbasmanova