Optimize Presto Serialization #8029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
reviewed
Dec 14, 2023
| @@ -606,6 +606,129 @@ TEST_P(PrestoSerializerTest, emptyArrayOfRowVector) { | |||
| testRoundTrip(arrayOfRow); | |||
| } | |||
|
|
|||
| struct SerializeCase { | |||
There was a problem hiding this comment.
This is already moved to another file, remove
oerling
force-pushed
the
opt-ser2-pr
branch
2 times, most recently
from
4352ecd to
bb68c45
Compare
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
approved these changes
Dec 18, 2023
oerling
pushed a commit
to oerling/velox-1
that referenced
this pull request
Dec 19, 2023
Summary: Uses serialization API that takes rows instead or ranges in PartitionedOutput. 1.5 - 2x more efficient CPU-wise. Reviewed By: Yuhta Differential Revision: D52142395 Pulled By: oerling
|
This pull request was exported from Phabricator. Differential Revision: D52142395 |
Uses serialization API that takes rows instead or ranges in PartitionedOutput. 1.5 - 2x more efficient CPU-wise.
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses serialization API that takes rows instead or ranges in PartitionedOutput. 1.5 - 2x more efficient CPU-wise.