Extract AggregationFuzzerBase from AggregationFuzzer #7916

kagamiori · 2023-12-07T18:50:53Z

Summary: Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer
that reuses common logic in AggregaitonFuzzerBase.

This diff also moves fuzzer-related files to
velox/exec/fuzzer, including
– AggregationFuzzer.h/cpp
– AggregationFuzzerRunner.h
– ReferenceQueryRunner.h
– DuckQueryRunner.h/cpp
– PrestoQueryRunner.h/cpp
– InputGenerator.h
– ResultVerifier.h
– TransformResultVerifier.h

It also moves the Presto functions' custom input generators and result verifiers to
velox/functions/prestosql/fuzzer, including
– MinMaxInputGenerator.h
– ApproxDistinctInputGenerator.h
– ApproxDistinctResultVerifier.h
– ApproxPercentileInputGenerator.h
– ApproxPercentileResultVerifier.h

This is the first piece of #7754.

Differential Revision: D51692940

netlify · 2023-12-07T18:51:02Z

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	`e2a25a1`
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/657b728ed5fbf400086d0331

facebook-github-bot · 2023-12-07T18:51:02Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. Differential Revision: D51692940

facebook-github-bot · 2023-12-08T04:05:15Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. Differential Revision: D51692940

facebook-github-bot · 2023-12-08T04:06:22Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. Differential Revision: D51692940

facebook-github-bot · 2023-12-08T18:37:51Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This is the first piece of facebookincubator#7754. Differential Revision: D51692940

facebook-github-bot · 2023-12-08T18:39:22Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This is the first piece of facebookincubator#7754. Differential Revision: D51692940

facebook-github-bot · 2023-12-08T18:59:35Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This is the first piece of facebookincubator#7754. Differential Revision: D51692940

facebook-github-bot · 2023-12-08T19:03:04Z

This pull request was exported from Phabricator. Differential Revision: D51692940

mbasmanova · 2023-12-08T20:13:48Z

velox/exec/tests/utils/AggregationFuzzerUtils.h

+
+namespace facebook::velox::exec::test {
+
+class MinMaxInputGenerator : public InputGenerator {


Let's put each of these classes into its own file or put all input generators into one file and options into its own file. BTW, input generators are specific to functions / dialect. Hence, these should not be placed into a "generic" location.

mbasmanova · 2023-12-08T20:14:47Z

velox/exec/tests/utils/AggregationFuzzerBase.h

+
+constexpr const std::string_view kPlanNodeFileName = "plan_nodes";
+
+class InputGenerator {


Let's move this into its own file. Same for ResultVerifier.

…or#7916) Summary: Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This is the first piece of facebookincubator#7754. Differential Revision: D51692940

facebook-github-bot · 2023-12-08T23:58:44Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This is the first piece of facebookincubator#7754. Differential Revision: D51692940

facebook-github-bot · 2023-12-13T23:12:42Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Differential Revision: D51692940 fbshipit-source-id: 03c558cf62d5a755705e4cb021a00785ae57e9e3

kagamiori · 2023-12-14T00:10:08Z

@kagamiori Wei, thank you for iterating on this PR. Overall looks good % some questions and CI being all red.

Hi @mbasmanova, thank you for the review! I've addressed your comments. I've tested the build on Mac using cmake, so the red signals should be gone this time. Could you take a look again? Thanks!

mbasmanova

Thanks.

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer and the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer. This is the first piece of facebookincubator#7754. Differential Revision: https://internalfb.com/D51692940 fbshipit-source-id: 384045c5b08c2e41cffa298a86cb5b434c6d05e5

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer and the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer. This is the first piece of facebookincubator#7754. Differential Revision: https://internalfb.com/D51692940 fbshipit-source-id: ad246bec3481d88527ad5df7313c9db69a229970

facebook-github-bot · 2023-12-14T19:12:55Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D51692940 fbshipit-source-id: 20fe59bbeb6c23f006380fcb98986a0d042cb322

facebook-github-bot · 2023-12-14T19:20:28Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D51692940 fbshipit-source-id: 78a56f59e0c76d53b6e5ced333fd6a91f1421d66

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Differential Revision: https://internalfb.com/D51692940 fbshipit-source-id: 029cca18ae8bb3aac2797e483b66f20e71d065c1

facebook-github-bot · 2023-12-14T21:18:19Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D51692940 fbshipit-source-id: cf8aec101f9d0b8d47a0db1e66e5f9b651f10414

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D51692940 fbshipit-source-id: 18d6e191d46f1f3eb69e8be8c24049cbc4a25d31

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Differential Revision: https://internalfb.com/D51692940 fbshipit-source-id: 135b93d52c2ca43cf3e9bc8abb971a46d367d3f1

facebook-github-bot · 2023-12-14T21:24:22Z

This pull request was exported from Phabricator. Differential Revision: D51692940

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Differential Revision: https://internalfb.com/D51692940 fbshipit-source-id: 8ca5f6772c43d5659f3410b49f15a0afa0d60884

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Differential Revision: https://internalfb.com/D51692940 fbshipit-source-id: 5e343ec133504a02e0415782f89c1b452c24d669

…or#7916) Summary: Pull Request resolved: facebookincubator#7916 Extract AggregationFuzzerBase from AggregationFuzzer. This is needed for building WindowFuzzer that reuses common logic in AggregaitonFuzzerBase. This diff also moves fuzzer-related files to velox/exec/fuzzer, including – AggregationFuzzer.h/cpp – AggregationFuzzerRunner.h – ReferenceQueryRunner.h – DuckQueryRunner.h/cpp – PrestoQueryRunner.h/cpp – InputGenerator.h – ResultVerifier.h – TransformResultVerifier.h It also moves the Presto functions' custom input generators and result verifiers to velox/functions/prestosql/fuzzer, including – MinMaxInputGenerator.h – ApproxDistinctInputGenerator.h – ApproxDistinctResultVerifier.h – ApproxPercentileInputGenerator.h – ApproxPercentileResultVerifier.h This is the first piece of facebookincubator#7754. Differential Revision: https://internalfb.com/D51692940 fbshipit-source-id: c1858f9f2a34eb292e59f80dcac4df9217c7c473

facebook-github-bot · 2023-12-14T23:40:37Z

This pull request has been merged in 3206691.

conbench-facebook · 2023-12-15T00:05:13Z

Conbench analyzed the 1 benchmark run on commit 32066911.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 7, 2023

facebook-github-bot added the fb-exported label Dec 7, 2023

kagamiori force-pushed the export-D51692940 branch from 0b132e2 to 9d5f34c Compare December 8, 2023 04:05

kagamiori force-pushed the export-D51692940 branch from 9d5f34c to c126fee Compare December 8, 2023 04:06

kagamiori force-pushed the export-D51692940 branch from c126fee to 4f486b6 Compare December 8, 2023 18:37

kagamiori force-pushed the export-D51692940 branch from 4f486b6 to 5996c4c Compare December 8, 2023 18:39

kagamiori force-pushed the export-D51692940 branch from 5996c4c to 044b938 Compare December 8, 2023 18:59

kagamiori force-pushed the export-D51692940 branch from 044b938 to a524c69 Compare December 8, 2023 19:02

mbasmanova reviewed Dec 8, 2023

View reviewed changes

kagamiori force-pushed the export-D51692940 branch from a524c69 to 0b22e60 Compare December 8, 2023 23:58

kagamiori force-pushed the export-D51692940 branch from 0b22e60 to 9ff2939 Compare December 9, 2023 00:29

kagamiori force-pushed the export-D51692940 branch from b37a7dd to d813f25 Compare December 13, 2023 23:12

kagamiori requested a review from mbasmanova December 14, 2023 00:07

mbasmanova approved these changes Dec 14, 2023

View reviewed changes

kagamiori force-pushed the export-D51692940 branch from d813f25 to 544f4ff Compare December 14, 2023 19:12

kagamiori force-pushed the export-D51692940 branch from 544f4ff to a02bb1b Compare December 14, 2023 19:20

kagamiori force-pushed the export-D51692940 branch from a02bb1b to 87cb8c1 Compare December 14, 2023 21:18

kagamiori force-pushed the export-D51692940 branch from 87cb8c1 to e2a25a1 Compare December 14, 2023 21:24

facebook-github-bot closed this in 3206691 Dec 14, 2023

facebook-github-bot added the Merged label Dec 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract AggregationFuzzerBase from AggregationFuzzer #7916

Extract AggregationFuzzerBase from AggregationFuzzer #7916

kagamiori commented Dec 7, 2023 •

edited

Loading

netlify bot commented Dec 7, 2023 •

edited

Loading

facebook-github-bot commented Dec 7, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

mbasmanova Dec 8, 2023

mbasmanova Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 13, 2023

kagamiori commented Dec 14, 2023

mbasmanova left a comment

facebook-github-bot commented Dec 14, 2023

facebook-github-bot commented Dec 14, 2023

facebook-github-bot commented Dec 14, 2023

facebook-github-bot commented Dec 14, 2023

facebook-github-bot commented Dec 14, 2023

conbench-facebook bot commented Dec 15, 2023


		namespace facebook::velox::exec::test {

		class MinMaxInputGenerator : public InputGenerator {


		constexpr const std::string_view kPlanNodeFileName = "plan_nodes";

		class InputGenerator {

Extract AggregationFuzzerBase from AggregationFuzzer #7916

Extract AggregationFuzzerBase from AggregationFuzzer #7916

Conversation

kagamiori commented Dec 7, 2023 • edited Loading

netlify bot commented Dec 7, 2023 • edited Loading

✅ Deploy Preview for meta-velox canceled.

facebook-github-bot commented Dec 7, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 8, 2023

mbasmanova Dec 8, 2023

Choose a reason for hiding this comment

mbasmanova Dec 8, 2023

Choose a reason for hiding this comment

facebook-github-bot commented Dec 8, 2023

facebook-github-bot commented Dec 13, 2023

kagamiori commented Dec 14, 2023

mbasmanova left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Dec 14, 2023

facebook-github-bot commented Dec 14, 2023

facebook-github-bot commented Dec 14, 2023

facebook-github-bot commented Dec 14, 2023

facebook-github-bot commented Dec 14, 2023

conbench-facebook bot commented Dec 15, 2023

kagamiori commented Dec 7, 2023 •

edited

Loading

netlify bot commented Dec 7, 2023 •

edited

Loading