Adding at_timezone feature #7708
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
svm1
changed the title
svm1
force-pushed
the
at_timezone
branch
2 times, most recently
from
967e216 to
459a624
Compare
| std::chrono::system_clock::time_point tp{std::chrono::seconds{ts.getSeconds()}}; | ||
|
|
||
| // Africa/Abidjan has offset +00:00 -> use this timezone to establish UTC as starting offset | ||
| auto startZonedTime = date::make_zoned("Africa/Abidjan", tp); |
There was a problem hiding this comment.
I was using the terms interchangeably as they are practically equivalent in this context - can replace with GMT. My point was that the input time is to be interpreted at GMT, so the Africa/Abidjan timezone, with offset of +00:00, is used to construct a starting timepoint based on the input timestamp.
There was a problem hiding this comment.
can we not use the actual string "GMT" for clarity?
|
@svm1 Sorry about the delay in getting back at this PR; somehow I lost the notification. Feel free to ping me on Slack if things hang around for too long. |
|
Thanks for looking over @pedroerp - I must apologize now, I must've missed your ping over the holiday season! After clarifying my understanding of the |
…racting UTC ts via sys_time(), init remains issue
|
@svm1 are you planning to get back to finish this PR? |
|
@pedroerp I opened a new PR for the same here - #8554. I initially split the PR into two, for the |
|
@svm1 sounds good, I'll check that one. Can you close this one? |
Adding at_timezone ("timestamp at timezone") feature.