Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add API to return function signatures by name #12289

Closed

Conversation

mbasmanova
Copy link
Contributor

Summary:
Add velox::getFunctionSignatures(name) API to get a list of function signatures by name.

Use this API to optimize lambda function resolution logic.

Differential Revision: D69368657

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 9, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69368657

Copy link

netlify bot commented Feb 9, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 73a7ae9
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67a8f67a7adb5c0008ac9c1f

@mbasmanova mbasmanova changed the title Add API to return function signatures by name feat: Add API to return function signatures by name Feb 9, 2025
mbasmanova added a commit to mbasmanova/velox-1 that referenced this pull request Feb 9, 2025
…r#12289)

Summary:

Add velox::getFunctionSignatures(name) API to get a list of function signatures by name.

Use this API to optimize lambda function resolution logic.

Differential Revision: D69368657
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69368657

…r#12289)

Summary:

Add velox::getFunctionSignatures(name) API to get a list of function signatures by name.

Use this API to optimize lambda function resolution logic.

Differential Revision: D69368657
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69368657

@mbasmanova
Copy link
Contributor Author

CI failure is due to a flaky test #6984

Copy link
Contributor

@pedroerp pedroerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @mbasmanova

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b673c2d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants