Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Minor cleanups for variant::serialize #12275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Minor cleanups for variant::serialize #12275

wants to merge 1 commit into from

Conversation

zhztheplayer
Copy link
Contributor

@zhztheplayer zhztheplayer commented Feb 6, 2025 •
edited
Loading

  1. Wrong variable name row at line 500 (likely a typo). Correct to array.
  2. Duplicated reference to variantObj["value"].

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 284c555
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67a44290f3b39400086c2412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhztheplayer @facebook-github-bot