Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix merge storageStats_ in IoStatistics #12263

Closed
wants to merge 1 commit into from
Closed

fix: Fix merge storageStats_ in IoStatistics #12263

wants to merge 1 commit into from

Conversation

kewang1024
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b1c7982
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67a3a0a89e981a0008dcef36

@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

kewang1024 added a commit to kewang1024/velox that referenced this pull request Feb 5, 2025
@kewang1024 @facebook-github-bot
fix: Fix merge storageStats_ in IoStatistics (facebookincubator#12263)
74bfff6 
Summary: Pull Request resolved: facebookincubator#12263

Differential Revision: D69172665

Pulled By: kewang1024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69172665

kewang1024 added a commit to kewang1024/velox that referenced this pull request Feb 5, 2025
@kewang1024 @facebook-github-bot
fix: Fix merge storageStats_ in IoStatistics (facebookincubator#12263)
5b67af1 
Summary: Pull Request resolved: facebookincubator#12263

Differential Revision: D69172665

Pulled By: kewang1024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69172665

kewang1024 added a commit to kewang1024/velox that referenced this pull request Feb 5, 2025
@kewang1024 @facebook-github-bot
fix: Fix merge storageStats_ in IoStatistics (facebookincubator#12263)
bb230e3 
Summary: Pull Request resolved: facebookincubator#12263

Differential Revision: D69172665

Pulled By: kewang1024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69172665

@kewang1024 kewang1024 requested a review from Yuhta February 5, 2025 10:20
kewang1024 added a commit to kewang1024/velox that referenced this pull request Feb 5, 2025
@kewang1024 @facebook-github-bot
fix: Fix merge storageStats_ in IoStatistics (facebookincubator#12263)
a0dac03 
Summary: Pull Request resolved: facebookincubator#12263

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

Without the fix, unit test would fail.
With the fix, unit test now passes

Differential Revision: D69172665

Pulled By: kewang1024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69172665

Yuhta
Yuhta approved these changes Feb 5, 2025
View reviewed changes
velox/common/io/IoStatistics.cpp Outdated Show resolved Hide resolved
@kewang1024 @facebook-github-bot
fix: Fix merge storageStats_ in IoStatistics (facebookincubator#12263)
b1c7982 
Summary: Pull Request resolved: facebookincubator#12263

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

Without the fix, unit test would fail.
With the fix, unit test now passes

Reviewed By: Yuhta

Differential Revision: D69172665

Pulled By: kewang1024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69172665

@facebook-github-bot
Copy link
Contributor

@kewang1024 merged this pull request in a6644b9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuhta Yuhta Yuhta approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kewang1024 @facebook-github-bot @Yuhta