-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capacity() getter to ApproxMostFrequentStreamSummary #12212
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D68870501 |
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
approved these changes
Jan 30, 2025
eb88399
to
1a2423d
Compare
deepyeet
pushed a commit
to deepyeet/velox
that referenced
this pull request
Jan 31, 2025
…ubator#12212) Summary: # Context This diff adds a simple getter to retrieve the capacity parameter (after we hit setCapacity()). We use this internally to perform some sanity checking when we have potentially two different SteamSummaries and we want to ensure capacities are in a sane spot. This seems reasonably safe to add, the capacity is set by the user and having something to read back out the set value doesn't seem too dangerous. It's also good for sanity checks and unit tests - e.g. as deserializing a stream summary gives back 0 capacity. Reviewed By: Yuhta Differential Revision: D68870501
This pull request was exported from Phabricator. Differential Revision: D68870501 |
…ubator#12212) Summary: # Context This diff adds a simple getter to retrieve the capacity parameter (after we hit setCapacity()). We use this internally to perform some sanity checking when we have potentially two different SteamSummaries and we want to ensure capacities are in a sane spot. This seems reasonably safe to add, the capacity is set by the user and having something to read back out the set value doesn't seem too dangerous. It's also good for sanity checks and unit tests - e.g. as deserializing a stream summary gives back 0 capacity. Reviewed By: Yuhta Differential Revision: D68870501
1a2423d
to
e2478ce
Compare
This pull request was exported from Phabricator. Differential Revision: D68870501 |
This pull request has been merged in 8a3aa63. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
This diff adds a simple getter to retrieve the capacity parameter (after we hit setCapacity()).
We use this internally to perform some sanity checking when we have potentially two different SteamSummaries and we want to ensure capacities are in a sane spot.
This seems reasonably safe to add, the capacity is set by the user and having something to read back out the set value doesn't seem too dangerous. It's also good for sanity checks and unit tests - e.g. as deserializing a stream summary gives back 0 capacity.
Differential Revision: D68870501