Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capacity() getter to ApproxMostFrequentStreamSummary #12212

Closed
wants to merge 1 commit into from

Conversation

deepyeet
Copy link

Summary:

Context

This diff adds a simple getter to retrieve the capacity parameter (after we hit setCapacity()).

We use this internally to perform some sanity checking when we have potentially two different SteamSummaries and we want to ensure capacities are in a sane spot.

This seems reasonably safe to add, the capacity is set by the user and having something to read back out the set value doesn't seem too dangerous. It's also good for sanity checks and unit tests - e.g. as deserializing a stream summary gives back 0 capacity.

Differential Revision: D68870501

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68870501

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit e2478ce
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/679d61facf498e00089ea969

deepyeet pushed a commit to deepyeet/velox that referenced this pull request Jan 31, 2025
…ubator#12212)

Summary:

# Context

This diff adds a simple getter to retrieve the capacity parameter (after we hit setCapacity()).

We use this internally to perform some sanity checking when we have potentially two different SteamSummaries and we want to ensure capacities are in a sane spot.

This seems reasonably safe to add, the capacity is set by the user and having something to read back out the set value doesn't seem too dangerous. It's also good for sanity checks and unit tests - e.g. as deserializing a stream summary gives back 0 capacity.

Reviewed By: Yuhta

Differential Revision: D68870501
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68870501

…ubator#12212)

Summary:

# Context

This diff adds a simple getter to retrieve the capacity parameter (after we hit setCapacity()).

We use this internally to perform some sanity checking when we have potentially two different SteamSummaries and we want to ensure capacities are in a sane spot.

This seems reasonably safe to add, the capacity is set by the user and having something to read back out the set value doesn't seem too dangerous. It's also good for sanity checks and unit tests - e.g. as deserializing a stream summary gives back 0 capacity.

Reviewed By: Yuhta

Differential Revision: D68870501
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68870501

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 8a3aa63.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants