feat: Implement map_keys_by_top_n_values function in Velox #12209
+232
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D68812985 |
duxiao1212
changed the title
…or#12209) Summary: Implement map_keys_by_top_n_values function in Velox ; the function returns the top N keys of the given map in descending order according to the natural ordering of its values. Differential Revision: D68812985
duxiao1212
force-pushed
the
export-D68812985
branch
from
b50ee28 to
bcd84eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68812985 |
duxiao1212
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D68812985 |
zacw7
reviewed
Jan 30, 2025
| const size_t ttlSize = | ||
| std::min(static_cast<size_t>(n), static_cast<size_t>(inputMap.size())); | ||
|
|
||
| std::vector<It> container; |
There was a problem hiding this comment.
curious why do we need this container and another result?
|
Could you please add the doc for this function here: https://github.com/facebookincubator/velox/blob/main/velox/docs/functions/presto/map.rst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implement map_keys_by_top_n_values function in Velox ;
the function returns the top N keys of the given map in descending order according to the natural ordering of its values.
Differential Revision: D68812985