Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert array_has_duplicates unit test due to Linux/Ubuntu test mismatch #12203

Closed

Conversation

peterenescu
Copy link
Contributor

Summary: New unit test for array_has_duplicates fails on Linux but not Ubuntu. Undoing the addition temporarily while we investigate the issue in case it's a result of added Json functionality

Differential Revision: D68845988

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68845988

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit c410157
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/679a9f26182e510008dc858c

@peterenescu peterenescu changed the title revert: Revert array_has_duplicates unit test due to Linux/Ubuntu test mismatch fix: Revert array_has_duplicates unit test due to Linux/Ubuntu test mismatch Jan 29, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68845988

peterenescu added a commit to peterenescu/velox that referenced this pull request Jan 29, 2025
…ismatch (facebookincubator#12203)

Summary:
Pull Request resolved: facebookincubator#12203

New unit test for array_has_duplicates fails on Linux but not Ubuntu. Undoing the addition temporarily while we investigate the issue in case it's a result of added Json functionality

Reviewed By: bikramSingh91

Differential Revision: D68845988
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68845988

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68845988

peterenescu added a commit to peterenescu/velox that referenced this pull request Jan 29, 2025
…ismatch (facebookincubator#12203)

Summary:
Pull Request resolved: facebookincubator#12203

New unit test for array_has_duplicates fails on Linux but not Ubuntu. Undoing the addition temporarily while we investigate the issue in case it's a result of added Json functionality

Reviewed By: bikramSingh91

Differential Revision: D68845988
peterenescu added a commit to peterenescu/velox that referenced this pull request Jan 29, 2025
…ismatch (facebookincubator#12203)

Summary:

New unit test for array_has_duplicates fails on Linux but not Ubuntu. Undoing the addition temporarily while we investigate the issue in case it's a result of added Json functionality

Reviewed By: bikramSingh91

Differential Revision: D68845988
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68845988

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68845988

peterenescu added a commit to peterenescu/velox that referenced this pull request Jan 29, 2025
…ismatch (facebookincubator#12203)

Summary:
Pull Request resolved: facebookincubator#12203

New unit test for array_has_duplicates fails on Linux but not Ubuntu. Undoing the addition temporarily while we investigate the issue in case it's a result of added Json functionality

Reviewed By: bikramSingh91

Differential Revision: D68845988
…ismatch (facebookincubator#12203)

Summary:

New unit test for array_has_duplicates fails on Linux but not Ubuntu. Undoing the addition temporarily while we investigate the issue in case it's a result of added Json functionality

Reviewed By: bikramSingh91

Differential Revision: D68845988
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68845988

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3fd46c7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants