feat: Add JSON SerDe code for member field HiveConnectorSplit::bucketConversion #12178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
zhztheplayer
changed the title
…sion JSON SerDe code for the field `HiveConnectorSplit::bucketConversion` is missing. The patch adds it. Also, the field `HiveConnectorSplit::bucketConversion` is missing from HiveConnectorSplit's constructor. Adds it to the constructor. Related to facebookincubator#10228.
zhztheplayer
force-pushed
the
wip-j-serde-buckconv
branch
from
669356c to
a999b61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON SerDe code for the field
HiveConnectorSplit::bucketConversionis missing. The patch adds it.Also, the field is missing from HiveConnectorSplit's constructor. The patch has a fix for this.
Related to #10228.