Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make TPCH dbgen text buffer size consistent with Presto Java #12169

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions velox/connectors/tpch/tests/TpchConnectorTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ TEST_F(TpchConnectorTest, simple) {
makeFlatVector<int64_t>({0, 1, 1, 1, 4}),
// n_comment
makeFlatVector<StringView>({
"furiously regular requests. platelets affix furious",
"instructions wake quickly. final deposits haggle. final, silent theodolites ",
"asymptotes use fluffily quickly bold instructions. slyly bold dependencies sleep carefully pending accounts",
"ss deposits wake across the pending foxes. packages after the carefully bold requests integrate caref",
"usly ironic, pending foxes. even, special instructions nag. sly, final foxes detect slyly fluffily ",
" haggle. carefully final deposits detect slyly agai",
"al foxes promise slyly according to the regular accounts. bold requests alon",
"y alongside of the pending deposits. carefully special packages are about the ironic forges. slyly special ",
"eas hang ironic, silent packages. slyly regular packages are furiously over the tithes. fluffily bold",
"y above the carefully unusual theodolites. final dugouts are quickly across the furiously regular d",
}),
});
test::assertEqualVectors(expected, output);
Expand Down
3 changes: 2 additions & 1 deletion velox/tpch/gen/DBGenIterator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ class DBGenBackend {
// structures required by dbgen are populated.
DBGenContext dbgenCtx;
load_dists(
10 * 1024 * 1024, &dbgenCtx); // 10 MB buffer size for text generation.
300 * 1024 * 1024,
&dbgenCtx); // 300 MB buffer size for text generation.
}
~DBGenBackend() {
cleanup_dists();
Expand Down
Loading