test: Upgrade the version of Presto we compare fuzzers in CI against to 0.290 #12096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 0.290 Summary: We currently run Aggregation, Window, and Writer fuzzers comparing against Presto in CI jobs. They run Presto at version 0.288. There are known compatibility issues with this older version, e.g. set_agg and set_union are disabled in AggregationFuzzer because of this. 0.290 appears to be the latest release from Presto and addresses these (we should be able to enable set_agg and set_union after this). I ran the Aggregation, Window, and Writer fuzzers against this version of Presto for an hour and didn't see issues. We also already run AggregationFuzzer against Presto trunk (or close to it) for every PR internally. Differential Revision: D68280837
kevinwilfong
requested review from
assignUser and
majetideepak
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68280837 |
✅ Deploy Preview for meta-velox canceled.
|
kgpai
approved these changes
Jan 16, 2025
|
This pull request has been merged in 4ad5a8a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We currently run Aggregation, Window, and Writer fuzzers comparing against Presto in CI jobs.
They run Presto at version 0.288. There are known compatibility issues with this older version,
e.g. set_agg and set_union are disabled in AggregationFuzzer because of this.
0.290 appears to be the latest release from Presto and addresses these (we should be able to
enable set_agg and set_union after this).
I ran the Aggregation, Window, and Writer fuzzers against this version of Presto for an hour and
didn't see issues. We also already run AggregationFuzzer against Presto trunk (or close to it)
for every PR internally.
Differential Revision: D68280837