refactor(build): Separate thrift and arrow install on Linux #12034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
czentgr
force-pushed
the
cz_setup_thrift
branch
3 times, most recently
from
c2feb06 to
09c88c3
Compare
majetideepak
reviewed
Jan 9, 2025
majetideepak
reviewed
Jan 9, 2025
czentgr
force-pushed
the
cz_setup_thrift
branch
from
09c88c3 to
c28f5b0
Compare
majetideepak
approved these changes
Jan 10, 2025
|
@czentgr verified the build works as expected with this change. |
majetideepak
added
the
ready-to-merge
czentgr
force-pushed
the
cz_setup_thrift
branch
from
c28f5b0 to
43964d0
Compare
assignUser
approved these changes
Jan 10, 2025
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @czentgr, could you please rebase the PR onto the latest main? It's needed for merging. Thanks! |
czentgr
force-pushed
the
cz_setup_thrift
branch
from
43964d0 to
676cf92
Compare
This PR addresses two issues. 1. Address downloading reliability from archive.apache.org by switching to github. 2. Remove the bundling of thrift from arrow and make it a separate install. This follows a PR where the bundled version of arrow still bundles thrift but has changed download locations.
czentgr
force-pushed
the
cz_setup_thrift
branch
from
676cf92 to
5dc1212
Compare
|
@kagamiori FYI, I've rebased again. Thanks! |
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in 8480a60. |
|
Conbench analyzed the 0 benchmark runs that triggered this notification. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues.
This follows a PR where the bundled version of arrow still bundles thrift but has changed download locations.