Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): Use ccache instead of .ccache #11893

Closed
wants to merge 1 commit into from
Closed

build(ci): Use ccache instead of .ccache #11893

wants to merge 1 commit into from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Dec 17, 2024 •
edited
Loading

Jacob mentioned that files with the dot prefix are restricted from being uploaded and hence
the ccache is disabled.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit fef559d
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/676f1cf42d89f40008d8a997

@majetideepak majetideepak changed the title build(ci): use ccache instead of .ccache build(ci): use ccache instead of dot ccache Dec 17, 2024
@majetideepak majetideepak changed the title build(ci): use ccache instead of dot ccache build: use ccache instead of .ccache Dec 17, 2024
@majetideepak majetideepak changed the title build: use ccache instead of .ccache build(ci): Use ccache instead of .ccache Dec 17, 2024
czentgr
czentgr approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change.

@majetideepak majetideepak marked this pull request as ready for review December 27, 2024 21:31
@majetideepak majetideepak mentioned this pull request Jan 2, 2025
Open
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 4437b48.

@majetideepak majetideepak deleted the fix-macos branch January 9, 2025 23:42
athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
@majetideepak @athmaja-n
build(ci): Use ccache instead of .ccache (facebookincubator#11893)
65d0f8d 
Summary:
Jacob mentioned that files with the dot prefix are restricted from being uploaded and hence
the ccache is disabled.

Pull Request resolved: facebookincubator#11893

Reviewed By: Yuhta

Differential Revision: D67771145

Pulled By: kgpai

fbshipit-source-id: bda06c15150b27d381d774fce2531da6a74fb9a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czentgr czentgr czentgr approved these changes

@kgpai kgpai kgpai approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majetideepak @facebook-github-bot @kgpai @czentgr