misc: Allow to install shared lib gflags on centos9 #11889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
PHILO-HE
changed the title
|
Hi @assignUser, could you take a look? |
|
Hi @kgpai, could you merge this small patch if you have no comment? |
kgpai
added
the
ready-to-merge
|
@PHILO-HE will be merged by our oncall. |
|
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…r#11889) Summary: This pr just reverts one line of change by facebookincubator#10732. I think it is not necessary to fully align gflags build with velox build. It means we should set `BUILD_SHARED_LIBS=ON` for gflags when `VELOX_BUILD_SHARED=ON`, but it is not necessary to set `BUILD_SHARED_LIBS=OFF` for gflags when `VELOX_BUILD_SHARED=OFF`. We can just make the shared lib always be produced, as I also note `setup-ubuntu.sh` always installs shared gflags from package (see [link](https://github.com/facebookincubator/velox/blob/main/scripts/setup-ubuntu.sh#L120)). Another reason for this fix is, it is better to keep using same lib type (static or shared) for gflags and glog to avoid any potential issues. Related discussion on this issue: facebookincubator#10732 (comment) Pull Request resolved: facebookincubator#11889 Reviewed By: xiaoxmeng Differential Revision: D67414560 Pulled By: pedroerp fbshipit-source-id: a797f44c2b659ca680ac555928a9f9d64ac9c8f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr just reverts one line of change by #10732. I think it is not necessary to fully align gflags build with velox build. It means we should set
BUILD_SHARED_LIBS=ONfor gflags whenVELOX_BUILD_SHARED=ON, but it is not necessary to setBUILD_SHARED_LIBS=OFFfor gflags whenVELOX_BUILD_SHARED=OFF. We can just make the shared lib always be produced, as I also notesetup-ubuntu.shalways installs shared gflags from package (see link). Another reason for this fix is, it is better to keep using same lib type (static or shared) for gflags and glog to avoid any potential issues.Related discussion on this issue: #10732 (comment)