Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable fastpath reading for some data types in ORC #10939

Closed
wants to merge 1 commit into from
Closed

Disable fastpath reading for some data types in ORC #10939

wants to merge 1 commit into from

Conversation

wypb
Copy link
Contributor

@wypb wypb commented Sep 6, 2024 •
edited
Loading

As discussed in prestodb/presto#23037 (comment), we need to disable fastpath reads of some ORC data types, so that we can add TPCDS related tests in the Presto native module.

CC: @Yuhta @aditi-pandit

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 9ba4715
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66e175ee9c4a57000859592d

@wypb wypb mentioned this pull request Sep 6, 2024
Open
@wypb wypb force-pushed the disable_fastpath_orc branch 2 times, most recently from 74af92b to 7884385 Compare September 6, 2024 09:13
@Yuhta Yuhta added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Sep 6, 2024
aditi-pandit
aditi-pandit approved these changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wypb

@mbasmanova
Copy link
Contributor

@wypb Would you rebase this PR so we can merge it?

@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@wypb wypb force-pushed the disable_fastpath_orc branch from 44c7d69 to cec6528 Compare September 9, 2024 09:49
@wypb
Copy link
Contributor Author

wypb commented Sep 9, 2024

@mbasmanova I have synced the latest code.

@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mbasmanova
Copy link
Contributor

@wypb Would you rebase to resolve CI failures?

@wypb wypb force-pushed the disable_fastpath_orc branch from 9dc40db to adc060b Compare September 11, 2024 01:31
@wypb wypb force-pushed the disable_fastpath_orc branch from adc060b to 9ba4715 Compare September 11, 2024 10:50
@wypb
Copy link
Contributor Author

wypb commented Sep 11, 2024

@wypb Would you rebase to resolve CI failures?

Hi @mbasmanova I have rebase the latest code.

@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in d1ac079.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit d1ac0793.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@wypb wypb deleted the disable_fastpath_orc branch September 12, 2024 02:39
@Yuhta Yuhta mentioned this pull request Sep 12, 2024
Closed
athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
@wypb @athmaja-n
Disable fastpath reading for some data types in ORC (facebookincubato…
8a184a0 
…r#10939)

Summary:
As discussed in prestodb/presto#23037 (comment), we need to disable fastpath reads of some ORC data types, so that we can add TPCDS related tests in the Presto native module.

CC: Yuhta aditi-pandit

Pull Request resolved: facebookincubator#10939

Reviewed By: Yuhta

Differential Revision: D62373833

Pulled By: mbasmanova

fbshipit-source-id: f38c7959ffb72c1ecbda9c7de4631dfa5ee73e39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuhta Yuhta Yuhta approved these changes

@aditi-pandit aditi-pandit aditi-pandit approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wypb @mbasmanova @facebook-github-bot @Yuhta @aditi-pandit