Fuzzer Expression tests for Decimal functions #1968
Assignees
Comments
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this issue
Dec 15, 2023
facebook-github-bot
pushed a commit
that referenced
this issue
Sep 7, 2024
Summary: ArgumentTypeFuzzer could be used to generate argument types when constructing a decimal expression in the fuzzer test. However, given a result type, it is unable to produce argument types that satisfy the necessary constraints. To address this limitation, argument type generators for Presto and Spark decimal functions have been added. In this PR, ExpressionFuzzer takes a map from function name to an instance of the argument generator. Custom generators provided by Presto and Spark are used in the expression fuzzer test to generate argument types. Experimental fuzzer tests with decimal type enabled are added. #1968 Pull Request resolved: #9149 Reviewed By: kgpai Differential Revision: D62193491 Pulled By: gggrace14 fbshipit-source-id: 6a0d935c4df4bfe4af605010b7df23a062fefc5a
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this issue
Jan 10, 2025
) Summary: ArgumentTypeFuzzer could be used to generate argument types when constructing a decimal expression in the fuzzer test. However, given a result type, it is unable to produce argument types that satisfy the necessary constraints. To address this limitation, argument type generators for Presto and Spark decimal functions have been added. In this PR, ExpressionFuzzer takes a map from function name to an instance of the argument generator. Custom generators provided by Presto and Spark are used in the expression fuzzer test to generate argument types. Experimental fuzzer tests with decimal type enabled are added. facebookincubator#1968 Pull Request resolved: facebookincubator#9149 Reviewed By: kgpai Differential Revision: D62193491 Pulled By: gggrace14 fbshipit-source-id: 6a0d935c4df4bfe4af605010b7df23a062fefc5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The fuzzer test for decimal functions like "decimal_add" tries to resolve return type without binding the input arguments. This leads to test failures as the return type relies on input argument precision and scale.
https://app.circleci.com/pipelines/github/facebookincubator/velox/9911/workflows/572b620b-a5d1-46d2-bb14-592dfab8d16f/jobs/56835
The text was updated successfully, but these errors were encountered: