Skip to content

Commit

Permalink
let VeloxPromise move-ctor be noexcept (#12182)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #12182

It seems like the intention was for the `VeloxPromise` move-ctor to be `noexcept`.

Reviewed By: pedroerp

Differential Revision: D68715056

fbshipit-source-id: 37938e434d519f0302a325f1b25ad84f83e5d8d3
  • Loading branch information
yfeldblum authored and facebook-github-bot committed Jan 27, 2025
1 parent a55e9a2 commit cc264cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion velox/common/future/VeloxPromise.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class VeloxPromise : public folly::Promise<T> {
}
}

explicit VeloxPromise(VeloxPromise<T>&& other)
explicit VeloxPromise(VeloxPromise<T>&& other) noexcept
: folly::Promise<T>(std::move(other)),
context_(std::move(other.context_)) {}

Expand Down

0 comments on commit cc264cd

Please sign in to comment.