Skip to content

Commit

Permalink
misc: Add comment for failing tests in FIPS environments (#12188)
Browse files Browse the repository at this point in the history
Summary:
In FIPS enabled environments OpenSSL is restricting access to certain APIs due to them being insecure. Velox supports functions that calculate the results using these obsolete functions. The tests will fail if run.

Pull Request resolved: #12188

Reviewed By: kgpai

Differential Revision: D68746609

Pulled By: xiaoxmeng

fbshipit-source-id: c428ea8cd7170436f784d9dbab96282150983f1f
  • Loading branch information
czentgr authored and facebook-github-bot committed Jan 28, 2025
1 parent 805fe4b commit 68fcaa1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions velox/functions/prestosql/tests/BinaryFunctionsTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ TEST_F(BinaryFunctionsTest, HmacSha512) {
EXPECT_EQ(std::nullopt, hmacSha512(std::nullopt, "velox"));
}

// Note: this test fails in a FIPS enabled environment because OpenSSL restricts
// usage of MD5 for hmacs.
TEST_F(BinaryFunctionsTest, HmacMd5) {
const auto hmacMd5 = [&](std::optional<std::string> arg,
std::optional<std::string> key) {
Expand Down

0 comments on commit 68fcaa1

Please sign in to comment.