spark sql sum(real) return type is double

facebookincubator · May 15, 2024 · 173f521 · 173f521
1 parent 54db952
commit 173f521
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/velox/functions/sparksql/aggregates/SumAggregate.cpp b/velox/functions/sparksql/aggregates/SumAggregate.cpp
@@ -49,7 +49,7 @@ exec::AggregateRegistrationResult registerSum(
     bool overwrite) {
   std::vector<std::shared_ptr<exec::AggregateFunctionSignature>> signatures{
       exec::AggregateFunctionSignatureBuilder()
-          .returnType("real")
+          .returnType("double")
           .intermediateType("double")
           .argumentType("real")
           .build(),

diff --git a/velox/functions/sparksql/aggregates/tests/SumAggregationTest.cpp b/velox/functions/sparksql/aggregates/tests/SumAggregationTest.cpp
@@ -449,5 +449,16 @@ TEST_F(SumAggregationTest, decimalRangeOverflow) {
       {expected},
       {});
 }
+
+TEST_F(SumAggregationTest, sumFloat) {
+  auto data = makeRowVector({makeFlatVector<float>({2.00, 1.00})});
+  createDuckDbTable({data});
+
+  testAggregations(
+      [&](auto& builder) { builder.values({data}); },
+      {},
+      {"spark_sum(c0)"},
+      "SELECT sum(c0) FROM tmp");
+}
 } // namespace
 } // namespace facebook::velox::functions::aggregate::sparksql::test