-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨 [BUG] - CreateFile Step Fails when Directory in Path Does Not Exist #506
Labels
bug
Something isn't working
Comments
From the golang 1.23
Which makes me think that we might want to call MkdirAll function before creating a file |
inesusvet
added a commit
to inesusvet/TTPForge
that referenced
this issue
Aug 22, 2024
Summary: Resolves facebookincubator#506 Differential Revision: D61658174
inesusvet
added a commit
to inesusvet/TTPForge
that referenced
this issue
Aug 22, 2024
) Summary: From the golang 1.23 os/file.go ``` // Flags to OpenFile wrapping those of the underlying system. Not all // flags may be implemented on a given system. const ( // Exactly one of O_RDONLY, O_WRONLY, or O_RDWR must be specified. O_RDONLY int = syscall.O_RDONLY // open the file read-only. O_WRONLY int = syscall.O_WRONLY // open the file write-only. O_RDWR int = syscall.O_RDWR // open the file read-write. // The remaining values may be or'ed in to control behavior. O_APPEND int = syscall.O_APPEND // append data to the file when writing. O_CREATE int = syscall.O_CREAT // create a new file if none exists. O_EXCL int = syscall.O_EXCL // used with O_CREATE, file must not exist. O_SYNC int = syscall.O_SYNC // open for synchronous I/O. O_TRUNC int = syscall.O_TRUNC // truncate regular writable file when opened. ) ``` Which makes me think that we might want to call MkdirAll function before creating a file Pull Request resolved: facebookincubator#511 Resolves facebookincubator#506 Differential Revision: D61658174
inesusvet
pushed a commit
to inesusvet/TTPForge
that referenced
this issue
Aug 22, 2024
Summary: Resolves facebookincubator#506 Differential Revision: D61658174
inesusvet
added a commit
to inesusvet/TTPForge
that referenced
this issue
Aug 22, 2024
) Summary: From the golang 1.23 os/file.go ``` // Flags to OpenFile wrapping those of the underlying system. Not all // flags may be implemented on a given system. const ( // Exactly one of O_RDONLY, O_WRONLY, or O_RDWR must be specified. O_RDONLY int = syscall.O_RDONLY // open the file read-only. O_WRONLY int = syscall.O_WRONLY // open the file write-only. O_RDWR int = syscall.O_RDWR // open the file read-write. // The remaining values may be or'ed in to control behavior. O_APPEND int = syscall.O_APPEND // append data to the file when writing. O_CREATE int = syscall.O_CREAT // create a new file if none exists. O_EXCL int = syscall.O_EXCL // used with O_CREATE, file must not exist. O_SYNC int = syscall.O_SYNC // open for synchronous I/O. O_TRUNC int = syscall.O_TRUNC // truncate regular writable file when opened. ) ``` Which makes me think that we might want to call MkdirAll function before creating a file Pull Request resolved: facebookincubator#511 Resolves facebookincubator#506 Differential Revision: D61658174
inesusvet
added a commit
to inesusvet/TTPForge
that referenced
this issue
Aug 22, 2024
) Summary: From the golang 1.23 os/file.go ``` // Flags to OpenFile wrapping those of the underlying system. Not all // flags may be implemented on a given system. const ( // Exactly one of O_RDONLY, O_WRONLY, or O_RDWR must be specified. O_RDONLY int = syscall.O_RDONLY // open the file read-only. O_WRONLY int = syscall.O_WRONLY // open the file write-only. O_RDWR int = syscall.O_RDWR // open the file read-write. // The remaining values may be or'ed in to control behavior. O_APPEND int = syscall.O_APPEND // append data to the file when writing. O_CREATE int = syscall.O_CREAT // create a new file if none exists. O_EXCL int = syscall.O_EXCL // used with O_CREATE, file must not exist. O_SYNC int = syscall.O_SYNC // open for synchronous I/O. O_TRUNC int = syscall.O_TRUNC // truncate regular writable file when opened. ) ``` Which makes me think that we might want to call MkdirAll function before creating a file Pull Request resolved: facebookincubator#511 Resolves facebookincubator#506 Differential Revision: D61658174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Executing the
create_file
step fails when the path contains a directory or subdirectory that does not exist.Steps to Reproduce
/tmp
that does not exist./tmp/folder_does_not_exist/ttpforge_create_file_GMAdvgIrzT: no such file or directory
.Expected Behavior
createfile_test.go
indicates on Lines 54-60 that this functionality should not fail, and instead should create the necessary subdirectories.Any suggestions for fixing this bug?
This seems like an issue between how Afero works, and how the OS file system is working here.
More TBD
Relevant log output
The text was updated successfully, but these errors were encountered: