Skip to content

Commit

Permalink
Fix set tests
Browse files Browse the repository at this point in the history
Summary:
We had a pair of tests with the same label, which was confusing the
test infra. The tests were actually broken, but we didn't notice.

Reviewed By: malanka

Differential Revision: D69455363

fbshipit-source-id: b99dd8a71211ca60f677c531b63556e71fb7cf1e
  • Loading branch information
Simon Marlow authored and facebook-github-bot committed Feb 11, 2025
1 parent 79ac277 commit 28911ca
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions glean/test/tests/Angle/SetTest.hs
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,11 @@ setLimitTest = TestList
[ TestLabel "Fail when exceeding limit for nat set" $
testQuery @(Set Nat) [s| all (1|2) |]
"Set size limit exceeded for nat set. Max size: 8. Size: 9"
, TestLabel "Fail when exceeding limit for word set" $
, TestLabel "Fail when exceeding limit for byte set" $
testQuery @(Set Byte)
[s| all ( 1 : byte | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 ) |]
"Set size limit exceeded for byte set. Max size: 8. Size: 9"
, TestLabel "Fail when exceeding limit for word set" $
"Set size limit exceeded for nat set. Max size: 8. Size: 9"
, TestLabel "Fail when exceeding limit for string set" $
testQuery @(Set Text) [s| all ("foo"|"bar") |]
"Set size limit exceeded for standard set. Max size: 8. Size: 10"
]
Expand All @@ -174,7 +174,7 @@ testQuery query errMsg =
Left ffiExc -> do
let runtimeMsg =
Prelude.take (Prelude.length errMsg) (ffiErrorMessage ffiExc)
assertEqual "Exception" runtimeMsg errMsg
assertEqual "Exception" errMsg runtimeMsg
Right v -> do
print v
assert False

0 comments on commit 28911ca

Please sign in to comment.