Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHR_materials_unlit #61

Merged

Conversation

robertlong
Copy link
Contributor

Adds support for the pending KHR_materials_unlit glTF extension.

Todo:

  • Rename variables using the old KHR_materials_common extension

@zellski
Copy link
Contributor

zellski commented Jan 19, 2018

Thank you very much, @robertlong -- at a cursory glance this looks great; I'll do a final eyeballing in the weekend and push out a new build.

@zellski
Copy link
Contributor

zellski commented Jan 23, 2018

... soon. Work madness.

Copy link
Contributor

@zellski zellski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Robert! I am going to fix up some variable names and such, but I'll do that directly on master. Thanks for this PR!

@zellski zellski merged commit 7447942 into facebookincubator:master Feb 2, 2018
@robertlong
Copy link
Contributor Author

Oh great, thanks!

@robertlong robertlong deleted the feature/khr_materials_cmnConstant branch February 2, 2018 18:32
@yosun
Copy link

yosun commented Dec 1, 2019

Is this still working in the latest patch executable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants