Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option "--fbx-tmp-dir" #219

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Conversation

shrinktofit
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@shrinktofit
Copy link
Contributor Author

Sometimes user might not expect .fbm directory to be auto-generated into FBX file's directory.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zellski
Copy link
Contributor

zellski commented Aug 5, 2019

Thanks very much! Yes, it’s frustrated me at times that the SDK writes next to the source, which ought to be considered a R/O area. Looks like you might also have helped with non-ascii source files? Will verify and merge later today.

@shrinktofit
Copy link
Contributor Author

Looks like you might also have helped with non-ascii source files?

Yes. The fbxFileName is encoded as ANSI or Unicode in Windows. But FBXImporter::Initialize requires UTF-8 encoding. (For me, "Failed to load FBX file" if CJK path passed to command line.)

@zellski
Copy link
Contributor

zellski commented Aug 6, 2019

@shrinktofit About to merge this, but now I'm thinking perhaps we should improve the default behaviour? For example:

  • --fbx-tmp-dir-mode={auto/sdk/explicit}:
    • auto is default, and means call e.g. boost::temp_directory_path()
    • sdk is current behaviour
    • explicit requires --fbx-tmp-dir switch, as per your PR

@zellski zellski merged commit 648fdfb into facebookincubator:master Aug 6, 2019
@shrinktofit shrinktofit deleted the fbx-temp-dir branch September 2, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants