Further improvemens to texture resolution. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move towards std::string over char * and FbxString where convenient, - Make a clear distinction between textures whose image files have been located and those who haven't; warn early in the latter case. - Extend RawTexture so we always know logical name in FBX, original file name in FBX, and inferred location in local filesystem. - In non-binary mode, simply output the inferred local file basename as the URI; this will be the correct relative path as long as the texture files are located next to the .gltf and .bin files. Primary remaining urge for a follow-up PR: - We should be copying texture image files into the .gltf output folder, but before that we should switch to an off-the-shelf cross-platform file manipulation library like https://github.com/cginternals/cppfs. When we make that transition, all this texture resolution code will undergo another refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
located and those who haven't; warn early in the latter case.
name in FBX, and inferred location in local filesystem.
the URI; this will be the correct relative path as long as the texture
files are located next to the .gltf and .bin files.
Primary remaining urge for a follow-up PR:
but before that we should switch to an off-the-shelf cross-platform
file manipulation library like https://github.com/cginternals/cppfs.
When we make that transition, all this texture resolution code will
undergo another refactoring.