-
Notifications
You must be signed in to change notification settings - Fork 421
Conversation
yarn warns about this.
We had some issues with a particular node.js version > 7.0.0 --- somehow we managed to trigger a JIT crash! So this needs some testing with all our workloads. |
Interesting. The node environment that I have been building out shims for is 7! So it won't work with 6 atm. :) |
Can you run "npm run validate" on your system without any issue? If so, can you tell us which version of Node you are using to run it? |
The only place I can repro it is in tests though. It seems like a bug in contextify (the "vm" module used by the test runner). var vm = require('vm');
let script = new vm.Script(`
var global = this; var self = this;
Object.defineProperty(global, "p", {
configurable: true,
enumerable: true,
get: function () { throw new Error("42"); }
});
`, { cachedDataProduced: false });
script.runInNewContext({}); If that's the only case I think we should expand the allowed engine range so that people can use the npm package outside of contributing to the project itself (i.e. running tests). While we try to fix the test. |
So what happens is that https://github.com/nodejs/node/blob/v7.10.0/src/node_contextify.cc#L96-L117 |
I have been getting some additional timeouts in Test262 on this version. Let me know if we'll need to bump any timeout values. |
I find the timeouts to be non deterministic on my setup. Perhaps not too surprising. The time-out setting for the CI is a bit more generous. I'm OK with leaving things as is as long as CI does not get to be flaky. |
yarn warns about this.