This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Merge adjacent JOIN_GENERATORS with the same path conditions #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,32 @@ export class PathConditionsImplementation extends PathConditions { | |||
| this._failedNegativeImplications = undefined; | |||
| } | |||
|
|
|||
| // It makes the strong assumption that, in order for 2 path conditions to be equal, | |||
There was a problem hiding this comment.
I think you could make this more general by treating two sets of path conditions equivalent if set a implies all of the conditions in set b and vice versa. I.e. a <=> b is as good as a = b.
NTillmann
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
@NTillmann is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: Adjacent JOIN_GENERATORS with same path conditions are now merged for optimization.
This pull request attempts to tackle #2565. Some assumptions were made (for lack of certainty) but commented on for further improvement.