Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Facebook Swift SDK 0.3.0 #185

Merged
merged 2 commits into from
Oct 12, 2017
Merged

Facebook Swift SDK 0.3.0 #185

merged 2 commits into from
Oct 12, 2017

Conversation

gfosco
Copy link
Contributor

@gfosco gfosco commented Oct 11, 2017

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed The Facebook CLA has been signed label Oct 11, 2017
@gfosco gfosco requested a review from nlutsenko October 11, 2017 23:16
@nlutsenko nlutsenko added this to the 0.3.0 milestone Oct 11, 2017
@nlutsenko
Copy link
Contributor

Missed Configurations/Version.xcconfig file.

nlutsenko
nlutsenko previously requested changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@nlutsenko nlutsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update version to 0.3.0 in Configurations/Version.xcconfig, since it's going to be visible to binary builds (say Carthage).

@gfosco gfosco dismissed nlutsenko’s stale review October 11, 2017 23:40

Added this change.

nlutsenko
nlutsenko approved these changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@nlutsenko nlutsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, squash and merge!

@gfosco gfosco merged commit fe6df55 into master Oct 12, 2017
@gfosco gfosco deleted the release030 branch October 12, 2017 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlutsenko nlutsenko nlutsenko approved these changes

Assignees
No one assigned
Labels
CLA Signed The Facebook CLA has been signed
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gfosco @nlutsenko @facebook-github-bot