Split DOM into two classes: Document and DOM #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichub
changed the title
| private ArrayListAccumulator<Object> mCachedChildrenAccumulator; | ||
|
|
||
| public Document(DOMProvider.Factory factory) { | ||
| this.mFactory = factory; |
| Document doc = new Document(new AndroidDOMProviderFactory((Application)context.getApplicationContext())); | ||
|
|
||
| modules.add(new DOM(doc)); | ||
| modules.add(new CSS(doc)); |
There was a problem hiding this comment.
This makes it so that the CSS module also requires the same minimum API level as DOM. @jasta should comment on this too.
| @@ -226,18 +190,12 @@ public PerformSearchResponse performSearch(JsonRpcPeer peer, final JSONObject pa | |||
| params, | |||
| PerformSearchRequest.class); | |||
|
|
|||
| final Pattern queryPattern = Pattern.compile(Pattern.quote(request.query), Pattern.CASE_INSENSITIVE); | |||
| final ArrayListAccumulator<Integer> results = new ArrayListAccumulator<>(); | |||
There was a problem hiding this comment.
I think there's an opportunity to increase clarity here ... what do the integers inside of results represent? Are they node IDs? If so, calling this nodeIdResults might help to illuminate this fact.
|
Okay there's another round of feedback. This is shaping up well, despite how confusing it all is :) |
|
|
||
| public class AndroidDOMProviderFactory implements DOMProvider.Factory { | ||
| public final class AndroidDOMProviderFactory |
There was a problem hiding this comment.
rename class to AndroidDocumentProviderFactory
|
Looks like we're almost done here. You have some conflicts to resolve, then need to squash, and then I think we can merge! |
DOM now handles only the communication between Chrome and Stetho, whereas Document is responsible for accessing, modifying, and maintaining information about elements on the Android side. The motivation for this change is that DOM is not the only class that needs access to information about elements - CSS also needs this information. By splitting these classes up it is possible for both DOM and CSS to be able to get and set element data.
rickbrew
added a commit
that referenced
this pull request
Aug 17, 2015
Split DOM into two classes: Document and DOM
This was referenced Jan 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOM now handles only the communication between Chrome and Stetho, whereas Document is responsible for accessing, modifying, and maintaining information about elements on the Android side. The motivation for this change is that DOM is not the only class that needs access to information about elements - CSS also needs this information. By splitting these classes up it is possible for both DOM and CSS to be able to get and set element data.