Remove obsolete backupable_db.h, utility_db.h #9438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This also removes the obsolete names BackupableDBOptions and UtilityDB. API users must now use BackupEngineOptions and DBWithTTL::Open. In C API, `rocksdb_backupable_db_*` is replaced `rocksdb_backup_engine_*`. Similar renaming in Java API. In reference to facebook#9389 Test Plan: CI
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mrambacher
approved these changes
Jan 26, 2022
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebookincubator/Glean
that referenced
this pull request
Jan 27, 2022
Summary: Exact codemod: ``` perl -pi -e 's/backupable_db.h/backup_engine.h/g' `fbgs -l backupable_db.h` perl -pi -e 's/BackupableDBOptions/BackupEngineOptions/g' `fbgs -l BackupableDBOptions` perl -pi -e 's/backupable_db_options/backup_engine_options/g' `fbgs -l backupable_db_options` hg revert fbcode/rocksdb/ fbcode/internal_repo_rocksdb/ ``` Manually add extra #include for these (because of reduced transitive includes): ``` rocks/nfs_volume/nfs_volume_backup_test.cc stargate/StargateDb.h ``` In preparation for removing old header and names. See facebook/rocksdb#9438 Reviewed By: ajkr Differential Revision: D33780423 fbshipit-source-id: ed3078818c7964ffb50693b34b93b67ef8a2aae6
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This also removes the obsolete names BackupableDBOptions
and UtilityDB. API users must now use BackupEngineOptions and
DBWithTTL::Open. In C API,
rocksdb_backupable_db_*is replacedrocksdb_backup_engine_*. Similar renaming in Java API.In reference to #9389
Test Plan: CI