[Remote Compaction] Set Options File Number for CompactionInput under Mutex Lock

[jaykorean]

Summary

Options File Number to be read by remote worker is part of the CompactionServiceInput. We've been setting this in ProcessKeyValueCompactionWithCompactionService() while the db_mutex is not held. This needs to be accessed while the mutex is held. The value can change as part of SetOptions() -> RenameTempFileToOptionsFile() as in following.

rocksdb/db/db_impl/db_impl.cc

Lines 5595 to 5596 in e697219

	InstrumentedMutexLock l(&mutex_);
	versions_->options_file_number_ = options_file_number;

Keep this value in memory during CompactionJob::Prepare() which is called while the mutex is held, so that we can easily access this later without mutex when building the CompactionInput for the remote compaction.

Thanks to the crash test. This was surfaced after #13378 merged.

Test Plan

Unit Test

./compaction_service_test

Crash Test

COERCE_CONTEXT_SWITCH=1 COMPILE_WITH_TSAN=1 CC=clang-13 CXX=clang++-13 ROCKSDB_DISABLE_ALIGNED_NEW=1 USE_CLANG=1 make V=1 -j100 dbg

python3 -u tools/db_crashtest.py blackbox --enable_remote_compaction=1 

[facebook-github-bot]

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[jowlyzhang]

LGTM!

[facebook-github-bot]

@jaykorean merged this pull request in a30c020.