Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable and re-enable error injection before secondary db verification (
#13368) Summary: The crash tests are failing during secondary database verification due to a "truncated block read" error. #13366 attempted to resolve the issue by checking for injected errors. However, that did not work. It turns out that sometimes faults are injected yet the return status is still "OK." See https://github.com/facebook/rocksdb/blob/main/utilities/fault_injection_fs.cc#L1407-L1414 for an example: ```cpp } else if (Random::GetTLSInstance()->OneIn(8)) { assert(result); // For a small chance, set the failure to status but turn the // result to be empty, which is supposed to be caught for a check. *result = Slice(); msg << "empty result"; ctx->message = msg.str(); ret_fault_injected = true; ``` My hypothesis is that this particular fault injection is the root cause of the "truncated block read" error. Pull Request resolved: #13368 Test Plan: Hopefully the recurring crash tests start passing consistently for secondary db verification Reviewed By: hx235 Differential Revision: D69132024 Pulled By: archang19 fbshipit-source-id: 941406165a2fd306f10048614457261cda99d762
- Loading branch information