15.5 bump proptypes version #9403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix a breaking change which was not supposed to be included yet, we reverted the change in prop-types v15.5.7 and are now pulling that into React. Related to fixing facebook/prop-types#17
|
Probably CI will fail until we actually release the updated version of the 'prop-types' package. |
|
This change looks good, but maybe wait to merge until we've actually released prop-types 15.5.7? |
bvaughn
approved these changes
Apr 11, 2017
gaearon
requested changes
Apr 11, 2017
|
^^ I'll probably do this manually because our branches are a little messed up anyway and it's easier to do by hand during the release |
|
Closing as I did this manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix a breaking change which was not supposed to be included yet, we
reverted the change in prop-types v15.5.7 and are now pulling that into
React.
Related to fixing facebook/prop-types#17