-
Notifications
You must be signed in to change notification settings - Fork 47.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more info about refs in the documentation #8707
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2e1172e
Update refs-and-the-dom.md
gyfis 9fe19bc
Adds more specific information about the callback
gyfis c3b9869
Moved the ref callback description to the Caveats section
gyfis 0f9d58d
Fixed suggested nits
gyfis 73fa694
Replace 'each render pass' with 'updates'
gyfis 00985ee
Tweak the wording
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits:
during each render pass
=>during updates
(it's unnecessary), additionally to the mount/unmount call
so React needs to reset the old instance and set-up the new one
=>so React needs to clear the old ref and set up the new one
This side-effect of inline callback function can be avoided
=>You can avoid this
as a property on the class
=>as a bound method on the class
because class properties are a proposal and not universally knownin the average ref use case
=>in most cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions! I'm ok with all but replacing the mentioned render with updates, maybe I don't understand but when saying
it will get called twice during updates
, what updates? The DOM update? Props/State update? I think it may confuse readers; when we specifyduring render
directly, I think it's more technical, but more clear too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I've read the whole paragraph again, and
updates
is ok - it is mentioned afterwards that it's the render that creates the function. Thanks and sorry for the confusion!