Add selection and composition events on reference page #5142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Event names: | ||
|
|
||
| ``` | ||
| compositionEnd compositionStart compositionUpdate |
There was a problem hiding this comment.
This should be onCompositionEnd etc?
|
Thanks, just the one nit – do you mind squashing your commits too? |
added composition events to reference page added selection events to reference page
MaxPRafferty
force-pushed
the
add-selection-and-composition-events-on-reference-page
branch
from
4363181 to
48ada00
Compare
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@spicyj Thanks; added "on" to composition events and squashed commits. |
|
Thanks! |
jimfb
added a commit
that referenced
this pull request
Oct 12, 2015
…ion-events-on-reference-page Add selection and composition events on reference page
jimfb
added a commit
that referenced
this pull request
Oct 12, 2015
…ion-events-on-reference-page Add selection and composition events on reference page (cherry picked from commit 37c71a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#432
Note that this PR does not update the respective Korean, Italian, or Chinese translations of this page.