Stop transforming class -> className #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the broken examples too (`git grep class=`)
| 'class': 'className', | ||
| cxName: 'className' | ||
| }; | ||
|
|
||
| var JSX_ATTRIBUTE_TRANSFORMS = { | ||
| cxName: function(attr) { |
There was a problem hiding this comment.
We already killed this internally too, so I'll end up getting rid of it at the same time.
|
I wish github had like buttons... |
jeffmo
pushed a commit
that referenced
this pull request
Sep 10, 2013
Stop transforming class -> className
Closed
|
Would it be unreasonable to update the documentation examples to use "className" instead of "class". One would think that copying the examples would get you working code ... but no. |
|
@zpao updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been decided.
Going to sync the timing of this with all the internal things we need to fix, but getting it out there.
classandforto suggestclassNameandhtmlFor