Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] reorganize code for forked entrypoints #30702

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[Flight] reorganize code for forked entrypoints #30702

merged 1 commit into from
Aug 15, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Aug 14, 2024

This commit updates the file locations and bulid configurations for flight in preparation for new static entrypoints. This follows a structure similar to Fizz which has a unified build but exports methods from different top level entrypoints. This PR doesn't actually add the new top level entrypoints however, that will arrive in a later update.

@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 0:55am

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 14, 2024
@gnoff gnoff force-pushed the reorganize-flight branch from ea11ab4 to 9024c45 Compare August 14, 2024 23:02
@gnoff
[Flight] reorganize code for forked entrypoints
986778e 
This commit updates the file locations and bulid configurations for flight in preparation for new static entrypoints. This follows a structure similar to Fizz which has a unified build but exports methods from different top level entrypoints. This PR doesn't actually add the new top level entrypoints however, that will arrive in a later update.
@gnoff gnoff force-pushed the reorganize-flight branch from 9024c45 to 986778e Compare August 15, 2024 00:53
@react-sizebot
Copy link

Comparing: 7e8a06c...cd7bf45

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB
oss-experimental/react-server-dom-webpack/server.node.js +189.92% 0.25 kB 0.72 kB +85.00% 0.16 kB 0.30 kB
oss-stable-rc/react-server-dom-webpack/server.node.js +189.92% 0.25 kB 0.72 kB +85.00% 0.16 kB 0.30 kB
oss-stable-semver/react-server-dom-webpack/server.node.js +189.92% 0.25 kB 0.72 kB +85.00% 0.16 kB 0.30 kB
oss-stable/react-server-dom-webpack/server.node.js +189.92% 0.25 kB 0.72 kB +85.00% 0.16 kB 0.30 kB
oss-experimental/react-server-dom-turbopack/server.node.js +186.90% 0.25 kB 0.72 kB +84.47% 0.16 kB 0.30 kB
oss-stable-rc/react-server-dom-turbopack/server.node.js +186.90% 0.25 kB 0.72 kB +84.47% 0.16 kB 0.30 kB
oss-stable-semver/react-server-dom-turbopack/server.node.js +186.90% 0.25 kB 0.72 kB +84.47% 0.16 kB 0.30 kB
oss-stable/react-server-dom-turbopack/server.node.js +186.90% 0.25 kB 0.72 kB +84.47% 0.16 kB 0.30 kB
oss-experimental/react-server-dom-webpack/server.node.unbundled.js +175.75% 0.27 kB 0.74 kB +82.53% 0.17 kB 0.30 kB
oss-stable-rc/react-server-dom-webpack/server.node.unbundled.js +175.75% 0.27 kB 0.74 kB +82.53% 0.17 kB 0.30 kB
oss-stable-semver/react-server-dom-webpack/server.node.unbundled.js +175.75% 0.27 kB 0.74 kB +82.53% 0.17 kB 0.30 kB
oss-stable/react-server-dom-webpack/server.node.unbundled.js +175.75% 0.27 kB 0.74 kB +82.53% 0.17 kB 0.30 kB
oss-experimental/react-server-dom-turbopack/server.node.unbundled.js +173.16% 0.27 kB 0.74 kB +83.13% 0.17 kB 0.30 kB
oss-stable-rc/react-server-dom-turbopack/server.node.unbundled.js +173.16% 0.27 kB 0.74 kB +83.13% 0.17 kB 0.30 kB
oss-stable-semver/react-server-dom-turbopack/server.node.unbundled.js +173.16% 0.27 kB 0.74 kB +83.13% 0.17 kB 0.30 kB
oss-stable/react-server-dom-turbopack/server.node.unbundled.js +173.16% 0.27 kB 0.74 kB +83.13% 0.17 kB 0.30 kB
oss-experimental/react-server-dom-esm/server.node.js +170.83% 0.24 kB 0.65 kB +80.00% 0.16 kB 0.28 kB
oss-stable-rc/react-server-dom-esm/server.node.js +170.83% 0.24 kB 0.65 kB +80.00% 0.16 kB 0.28 kB
oss-stable-semver/react-server-dom-esm/server.node.js +170.83% 0.24 kB 0.65 kB +80.00% 0.16 kB 0.28 kB
oss-stable/react-server-dom-esm/server.node.js +170.83% 0.24 kB 0.65 kB +80.00% 0.16 kB 0.28 kB
oss-experimental/react-server-dom-webpack/server.edge.js +166.94% 0.25 kB 0.66 kB +78.13% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-webpack/server.edge.js +166.94% 0.25 kB 0.66 kB +78.13% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-webpack/server.edge.js +166.94% 0.25 kB 0.66 kB +78.13% 0.16 kB 0.29 kB
oss-stable/react-server-dom-webpack/server.edge.js +166.94% 0.25 kB 0.66 kB +78.13% 0.16 kB 0.29 kB
oss-experimental/react-server-dom-turbopack/server.edge.js +164.29% 0.25 kB 0.67 kB +77.64% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-turbopack/server.edge.js +164.29% 0.25 kB 0.67 kB +77.64% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-turbopack/server.edge.js +164.29% 0.25 kB 0.67 kB +77.64% 0.16 kB 0.29 kB
oss-stable/react-server-dom-turbopack/server.edge.js +164.29% 0.25 kB 0.67 kB +77.64% 0.16 kB 0.29 kB
oss-experimental/react-server-dom-webpack/server.browser.js +162.99% 0.25 kB 0.67 kB +77.16% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-webpack/server.browser.js +162.99% 0.25 kB 0.67 kB +77.16% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-webpack/server.browser.js +162.99% 0.25 kB 0.67 kB +77.16% 0.16 kB 0.29 kB
oss-stable/react-server-dom-webpack/server.browser.js +162.99% 0.25 kB 0.67 kB +77.16% 0.16 kB 0.29 kB
oss-experimental/react-server-dom-turbopack/server.browser.js +160.47% 0.26 kB 0.67 kB +76.69% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-turbopack/server.browser.js +160.47% 0.26 kB 0.67 kB +76.69% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-turbopack/server.browser.js +160.47% 0.26 kB 0.67 kB +76.69% 0.16 kB 0.29 kB
oss-stable/react-server-dom-turbopack/server.browser.js +160.47% 0.26 kB 0.67 kB +76.69% 0.16 kB 0.29 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/server.node.js +189.92% 0.25 kB 0.72 kB +85.00% 0.16 kB 0.30 kB
oss-stable-rc/react-server-dom-webpack/server.node.js +189.92% 0.25 kB 0.72 kB +85.00% 0.16 kB 0.30 kB
oss-stable-semver/react-server-dom-webpack/server.node.js +189.92% 0.25 kB 0.72 kB +85.00% 0.16 kB 0.30 kB
oss-stable/react-server-dom-webpack/server.node.js +189.92% 0.25 kB 0.72 kB +85.00% 0.16 kB 0.30 kB
oss-experimental/react-server-dom-turbopack/server.node.js +186.90% 0.25 kB 0.72 kB +84.47% 0.16 kB 0.30 kB
oss-stable-rc/react-server-dom-turbopack/server.node.js +186.90% 0.25 kB 0.72 kB +84.47% 0.16 kB 0.30 kB
oss-stable-semver/react-server-dom-turbopack/server.node.js +186.90% 0.25 kB 0.72 kB +84.47% 0.16 kB 0.30 kB
oss-stable/react-server-dom-turbopack/server.node.js +186.90% 0.25 kB 0.72 kB +84.47% 0.16 kB 0.30 kB
oss-experimental/react-server-dom-webpack/server.node.unbundled.js +175.75% 0.27 kB 0.74 kB +82.53% 0.17 kB 0.30 kB
oss-stable-rc/react-server-dom-webpack/server.node.unbundled.js +175.75% 0.27 kB 0.74 kB +82.53% 0.17 kB 0.30 kB
oss-stable-semver/react-server-dom-webpack/server.node.unbundled.js +175.75% 0.27 kB 0.74 kB +82.53% 0.17 kB 0.30 kB
oss-stable/react-server-dom-webpack/server.node.unbundled.js +175.75% 0.27 kB 0.74 kB +82.53% 0.17 kB 0.30 kB
oss-experimental/react-server-dom-turbopack/server.node.unbundled.js +173.16% 0.27 kB 0.74 kB +83.13% 0.17 kB 0.30 kB
oss-stable-rc/react-server-dom-turbopack/server.node.unbundled.js +173.16% 0.27 kB 0.74 kB +83.13% 0.17 kB 0.30 kB
oss-stable-semver/react-server-dom-turbopack/server.node.unbundled.js +173.16% 0.27 kB 0.74 kB +83.13% 0.17 kB 0.30 kB
oss-stable/react-server-dom-turbopack/server.node.unbundled.js +173.16% 0.27 kB 0.74 kB +83.13% 0.17 kB 0.30 kB
oss-experimental/react-server-dom-esm/server.node.js +170.83% 0.24 kB 0.65 kB +80.00% 0.16 kB 0.28 kB
oss-stable-rc/react-server-dom-esm/server.node.js +170.83% 0.24 kB 0.65 kB +80.00% 0.16 kB 0.28 kB
oss-stable-semver/react-server-dom-esm/server.node.js +170.83% 0.24 kB 0.65 kB +80.00% 0.16 kB 0.28 kB
oss-stable/react-server-dom-esm/server.node.js +170.83% 0.24 kB 0.65 kB +80.00% 0.16 kB 0.28 kB
oss-experimental/react-server-dom-webpack/server.edge.js +166.94% 0.25 kB 0.66 kB +78.13% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-webpack/server.edge.js +166.94% 0.25 kB 0.66 kB +78.13% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-webpack/server.edge.js +166.94% 0.25 kB 0.66 kB +78.13% 0.16 kB 0.29 kB
oss-stable/react-server-dom-webpack/server.edge.js +166.94% 0.25 kB 0.66 kB +78.13% 0.16 kB 0.29 kB
oss-experimental/react-server-dom-turbopack/server.edge.js +164.29% 0.25 kB 0.67 kB +77.64% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-turbopack/server.edge.js +164.29% 0.25 kB 0.67 kB +77.64% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-turbopack/server.edge.js +164.29% 0.25 kB 0.67 kB +77.64% 0.16 kB 0.29 kB
oss-stable/react-server-dom-turbopack/server.edge.js +164.29% 0.25 kB 0.67 kB +77.64% 0.16 kB 0.29 kB
oss-experimental/react-server-dom-webpack/server.browser.js +162.99% 0.25 kB 0.67 kB +77.16% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-webpack/server.browser.js +162.99% 0.25 kB 0.67 kB +77.16% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-webpack/server.browser.js +162.99% 0.25 kB 0.67 kB +77.16% 0.16 kB 0.29 kB
oss-stable/react-server-dom-webpack/server.browser.js +162.99% 0.25 kB 0.67 kB +77.16% 0.16 kB 0.29 kB
oss-experimental/react-server-dom-turbopack/server.browser.js +160.47% 0.26 kB 0.67 kB +76.69% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-turbopack/server.browser.js +160.47% 0.26 kB 0.67 kB +76.69% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-turbopack/server.browser.js +160.47% 0.26 kB 0.67 kB +76.69% 0.16 kB 0.29 kB
oss-stable/react-server-dom-turbopack/server.browser.js +160.47% 0.26 kB 0.67 kB +76.69% 0.16 kB 0.29 kB

Generated by 🚫 dangerJS against 986778e

@gnoff gnoff merged commit 8b08ee0 into facebook:main Aug 15, 2024
185 checks passed
@gnoff gnoff deleted the reorganize-flight branch August 15, 2024 01:10
@eps1lon eps1lon mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnoff @react-sizebot @sebmarkbage @facebook-github-bot