Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Allow hoisting of destructured variable declarations #30699

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

mvitousek
Copy link
Contributor

@mvitousek mvitousek commented Aug 14, 2024

Stack from ghstack (oldest at bottom):

Summary:
It doesn't seem as though this invariant was necessary

Summary:
It doesn't seem as though this invariant was necessary

[ghstack-poisoned]
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 9:30pm

mvitousek added a commit that referenced this pull request Aug 14, 2024
Summary:
It doesn't seem as though this invariant was necessary

ghstack-source-id: b27e76525911d5cfc1991b5cfdb7b2074c039e21
Pull Request resolved: #30699
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@mvitousek mvitousek merged commit 8f406e0 into gh/mvitousek/24/base Aug 15, 2024
19 checks passed
mvitousek added a commit that referenced this pull request Aug 15, 2024
Summary:
It doesn't seem as though this invariant was necessary

ghstack-source-id: b27e76525911d5cfc1991b5cfdb7b2074c039e21
Pull Request resolved: #30699
@mvitousek mvitousek deleted the gh/mvitousek/24/head branch August 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants