Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-plugin-react-hooks] Add flat/recommended config #29770

Closed
wants to merge 1 commit into from

Conversation

latin-1
Copy link
Contributor

@latin-1 latin-1 commented Jun 5, 2024

Addresses #28313

Summary

Add configs['flat/recommended'] to eslint-plugin-react-hooks.

How did you test this change?

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 4:44pm

@react-sizebot
Copy link

Comparing: eb259b5...4ac1767

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.26 kB 497.26 kB = 89.11 kB 89.11 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.08 kB 502.08 kB = 89.80 kB 89.80 kB
facebook-www/ReactDOM-prod.classic.js = 594.56 kB 594.56 kB = 104.72 kB 104.72 kB
facebook-www/ReactDOM-prod.modern.js = 570.95 kB 570.95 kB = 101.13 kB 101.13 kB
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +0.26% 77.75 kB 77.96 kB +0.40% 14.20 kB 14.26 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +0.26% 77.75 kB 77.96 kB +0.40% 14.20 kB 14.26 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +0.26% 77.75 kB 77.96 kB +0.40% 14.20 kB 14.26 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +0.26% 79.60 kB 79.81 kB +0.39% 14.45 kB 14.50 kB
oss-stable-rc/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +0.22% 94.60 kB 94.81 kB +0.14% 22.09 kB 22.12 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +0.22% 94.60 kB 94.81 kB +0.14% 22.09 kB 22.12 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +0.22% 94.60 kB 94.81 kB +0.14% 22.09 kB 22.12 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +0.22% 94.75 kB 94.96 kB +0.14% 22.12 kB 22.15 kB
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Generated by 🚫 dangerJS against 4ac1767

Copy link

github-actions bot commented Sep 3, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Sep 3, 2024
@latin-1
Copy link
Contributor Author

latin-1 commented Sep 3, 2024 via email

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Sep 3, 2024
Comment on lines +32 to +35
rules: {
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'warn',
},
Copy link

@burtek burtek Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is same in recommended and flat/recommended, how about assigning this to a const and reusing in both configs? It's not like the rulessets will differ from each other

Copy link

github-actions bot commented Dec 4, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Dec 4, 2024
@controversial
Copy link

bump

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Dec 4, 2024
@eps1lon
Copy link
Collaborator

eps1lon commented Jan 22, 2025

Sorry this fell through. Support for flat configs was added in #30774

@eps1lon eps1lon closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants