-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eslint-plugin-react-hooks] Add flat/recommended config #29770
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comparing: eb259b5...4ac1767 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
bump
…On Wed, Sep 4, 2024, 1:05 AM github-actions[bot] ***@***.***> wrote:
This pull request has been automatically marked as stale. *If this pull
request is still relevant, please leave any comment* (for example,
"bump"), and we'll keep it open. We are sorry that we haven't been able to
prioritize reviewing it yet. Your contribution is very much appreciated.
—
Reply to this email directly, view it on GitHub
<#29770 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKW5KC6MHF347GZGT6LXZOTZUXT6LAVCNFSM6AAAAABI3CYZSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGAZDKMRWHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
rules: { | ||
'react-hooks/rules-of-hooks': 'error', | ||
'react-hooks/exhaustive-deps': 'warn', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is same in recommended
and flat/recommended
, how about assigning this to a const and reusing in both configs? It's not like the rulessets will differ from each other
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
bump |
Sorry this fell through. Support for flat configs was added in #30774 |
Addresses #28313
Summary
Add
configs['flat/recommended']
to eslint-plugin-react-hooks.How did you test this change?