Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renderToPipeableStream#options.onShellError to match usage #24299

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Apr 7, 2022

Summary

onShellError is called with the error (tests, docs).

The changed line is linked from the docs to refer to as the "full list of options".

How did you test this change?

  • CI

@eps1lon eps1lon requested a review from sebmarkbage April 7, 2022 18:16
@eps1lon eps1lon marked this pull request as ready for review April 7, 2022 18:16
@sizebot
Copy link

sizebot commented Apr 7, 2022

Comparing: d68b09d...7574a84

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.40 kB 131.40 kB = 41.98 kB 41.99 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.45 kB 136.45 kB = 43.43 kB 43.43 kB
facebook-www/ReactDOM-prod.classic.js = 433.07 kB 433.07 kB = 79.60 kB 79.60 kB
facebook-www/ReactDOM-prod.modern.js = 418.07 kB 418.07 kB = 77.24 kB 77.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 433.07 kB 433.07 kB = 79.61 kB 79.61 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 7574a84

@gaearon gaearon merged commit 548b542 into facebook:main Apr 7, 2022
@eps1lon eps1lon deleted the fix/pipeable-stream-options branch April 7, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants