[react-interactions] Add DO_NOT_USE to Scope methods #17835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c3bde90:
|
Details of bundled changes.Comparing: f4ca909...c3bde90 react-native-renderer
react-reconciler
react-dom
react-art
react-test-renderer
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
trueadm
force-pushed
the
scope-child-context
branch
from
19b0a1e to
c3bde90
Compare
Details of bundled changes.Comparing: f4ca909...c3bde90 react-test-renderer
react-native-renderer
react-art
react-dom
react-reconciler
Size changes (experimental) |
trueadm
commented
Jan 14, 2020
| @@ -14,74 +14,11 @@ can be found [here](./docs). | |||
|
|
|||
| Note: React Scopes require the internal React flag `enableScopeAPI`. | |||
|
|
|||
| When creating a scope, a query function is required. The query function is used | |||
There was a problem hiding this comment.
I'm removing this document as we really don't want people to be actively using any of these APIs right now.
trueadm
added a commit
to trueadm/react
that referenced
this pull request
Jan 17, 2020
trueadm
added a commit
to trueadm/react
that referenced
this pull request
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempt to make it clearer about existing experimental APIs and their internal usage. In the long term, the Scopes API is expected to change/go-away but for now, given it's internal usage we'll have to find incremental ways to safely migrate to better options. This PR is one small step of many in order to do that. This PR makes the following changes:
DO_NOT_USEprefix to most Scope API methods that are potentially dangerous and will likely change or go away.getChildContextValuesthat attempts to work with existing React Context. It find the nearest child context values for a given type and returns them as part of an array. The idea is to internally use this approach and gradually deprecate and remove the DO_NOT_USE APIs.