[React Native] Fix for view config registrations #16821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elicwhite
approved these changes
Sep 18, 2019
rickhanlonii
commented
Sep 18, 2019
| // fail so that we don't mask the above failure. | ||
| expect(() => ReactNative.render(<InvalidEvents />, 1)).toThrow( | ||
| 'Event cannot be both direct and bubbling: topChange', | ||
| ); |
There was a problem hiding this comment.
Without the change in this PR, this test will fail because the view config is not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change fixes a behavior in the React Native view config registry which would hide errors when registering components.
Details
Before this change, even if we failed to register the view config for any reason (e.g. the events are invalid), we would still clear the callback for the view config.
This means, the next time that a user renders the component and we check for the view config, we would show this error:
This error is wrong. The real error is masked (and may never be shown, if the registration happened before error handling is set up), and may be something like:
This PR fixes this behavior by clearing the view config callback only after the view config is successfully registered.
Screen
Test