Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps in packages/**/package.json #16325

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Aug 8, 2019

No description provided.

@@ -20,7 +20,7 @@
"homepage": "https://reactjs.org/",
"peerDependencies": {
"jest": "^23.0.1",
"scheduler": "^0.11.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really bump this one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional that we didn't raise it past 0.11 previously? Or was that a mistake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API changed in 0.14 so yeah. It's private anyway so doesn't really matter.

@acdlite acdlite force-pushed the bump-source-deps-16.9 branch from 7a97008 to cfe3ff4 Compare August 8, 2019 21:44
@sizebot
Copy link

sizebot commented Aug 8, 2019

Warnings
⚠️

Base commit is broken: 85d05b3

Generated by 🚫 dangerJS

@acdlite
Copy link
Collaborator Author

acdlite commented Aug 8, 2019

I know sizebot I'm fixing it!

@acdlite acdlite merged commit 95767ac into facebook:master Aug 8, 2019
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants