Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rootEventTypes in DOMEventResponderSystem stopPropagation tests #15433

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Apr 17, 2019

Confirms that current logic correctly stops propagation of event type to the root.

We probably need to consider an alternative mechanism if we don't want event components to be able to influence the events received by event components of different types.

@necolas necolas force-pushed the react-dom/responder-propagation-with-root-events branch from dd1be14 to f65516f Compare April 17, 2019 18:33
@necolas necolas merged commit 0b50fb2 into facebook:master Apr 17, 2019
@necolas necolas deleted the react-dom/responder-propagation-with-root-events branch April 19, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants