Run Placeholder tests in persistent mode, too #15013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
changed the title
acdlite
force-pushed
the
persistent-placeholder-tests
branch
2 times, most recently
from
cd9f366 to
0c725b7
Compare
sebmarkbage
reviewed
Mar 5, 2019
acdlite
force-pushed
the
persistent-placeholder-tests
branch
2 times, most recently
from
1ac24c4 to
37fd3fb
Compare
This was referenced Mar 6, 2019
acdlite
force-pushed
the
persistent-placeholder-tests
branch
from
37fd3fb to
8066a4b
Compare
|
ReactDOM: size: -0.0%, gzip: -0.0% Details of bundled changes.Comparing: 1e3b619...9182e16 react-dom
react-art
react-native-renderer
react-test-renderer
react-noop-renderer
react-reconciler
Generated by 🚫 dangerJS |
Instead of the test renderer, since test renderer does not support running in persistent mode.
Adds a test for a subtle edge case that only occurs in persistent mode.
This sidesteps the problem where createHiddenTextInstance needs access to the host context.
acdlite
force-pushed
the
persistent-placeholder-tests
branch
from
8066a4b to
9182e16
Compare
sebmarkbage
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I screwed up a few months ago when I converted the Suspense placeholder tests to use test renderer instead of noop renderer — I forgot that we were using noop renderer because it supports both mutation and persistent mode. This PR corrects that mistake by converting them back to the noop renderer. This exposed bugs in our persistent implementation. (We don't use Suspense in persistent mode anywhere yet, but it's what Fabric will use.)
This indicates we should stop using test renderer for our internal React tests, and that we should probably be running all our tests in both modes by default. (I also found a bug related to profiler in persistent mode.) But I'll leave that for a follow up.